You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since there are clear previous similar PR being merged. I am very fine of these sort of PRs. You can automatically count an approval from me in these PRs.
But I don't think I have a say on these files. It is dangerous to have someone deciding whether to merge a PR or not into a code base that they have no idea of. Considering you are "fixing" one of David's tests, I think his approval is way more important and persuasive than me.
Also never mind to @ me in your future PRs :) but only when you think in most cases I can provide reliable help, or the best thing I can do for you is to request review from whom I biased-ly trusted in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #23123.